Skip to content

Read very old stata DTA files #12233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

kshedden
Copy link
Contributor

@kshedden kshedden commented Feb 5, 2016

This should close #12232, although the issue may resurface for files containing double values (I can't determine the old type code for doubles).

@jreback
Copy link
Contributor

jreback commented Feb 5, 2016

@kshedden looks good.

can you add a release note and fix flake8 issues (that's why the build failed)

@jreback jreback added IO Stata read_stata, to_stata Compat pandas objects compatability with Numpy or Python functions labels Feb 5, 2016
@jreback jreback added this to the 0.18.0 milestone Feb 5, 2016
@jreback
Copy link
Contributor

jreback commented Feb 6, 2016

looks good. minor flake8 issue to fix & pls add a release note & squash. ping when green.

Remove unused method

flake8 fixes, release note

minor formatting changes

flake8 fixes
@kshedden
Copy link
Contributor Author

kshedden commented Feb 7, 2016

@jreback it's squashed, etc. but I get what seems to be an unrelated test error (numexpr) on only one platform

@jreback jreback closed this in ca4f738 Feb 8, 2016
@jreback
Copy link
Contributor

jreback commented Feb 8, 2016

@kshedden thanks!

cldy pushed a commit to cldy/pandas that referenced this pull request Feb 11, 2016
Closes pandas-dev#12232, although the issue may resurface for files
containing double values (I can't determine the old type code for
doubles).

Author: Kerby Shedden <[email protected]>

Closes pandas-dev#12233 from kshedden/old_stata and squashes the following commits:

aba666c [Kerby Shedden] Read old stat files (bugfix)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions IO Stata read_stata, to_stata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue with StataReader for stata files versions 108 and older
2 participants