Skip to content

Conversation

@jreback
Copy link
Contributor

@jreback jreback commented Jan 28, 2016

DEPR: Removal of cols keyword in favor of subset in DataFrame.duplicated() and DataFrame.drop_duplicates(), xref #6680

@jreback jreback added the Deprecate Functionality to remove in pandas label Jan 28, 2016
@jreback jreback added this to the 0.18.0 milestone Jan 28, 2016
@jreback
Copy link
Contributor Author

jreback commented Jan 28, 2016

removing the float indexers change as it is a rabbit hole :) (meaning a different PR!)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you removed this?
As I think it is a valid kwarg?

In [155]: pd.Timestamp(5, unit='D')
Out[155]: Timestamp('1970-01-06 00:00:00')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shoot, you are right. was looking at something else. will revert

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Deprecate Functionality to remove in pandas

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants