BUG: force list type for tuples from chunked sql table reads #11522 #11861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| chunksize = 5 | ||
| chunk_gen = pd.read_sql_query(sql=query, con=self.conn, | ||
| chunksize=chunksize, index_col="index") | ||
| chunk_df = pd.DataFrame() |
There was a problem hiding this comment.
This line is superfluous
|
@grahamjeffries Looks good! thanks This is actually in code that is deprecated, and will be removed in the future. But as it is only a small change, ok to let this in for the case it will not yet be removed in the next version. |
|
Sure thing. Yeah, I wasn't quite sure what the protocol was for testing cases which fail with an exception. I'll update the PR |
|
@grahamjeffries OK! Just a last question, can you add a note in the whatsnew file (doc/source/whatsnew/v0.18.0.txt) in the bug fixes section, and then also squash the commits? (http://pandas.pydata.org/pandas-docs/stable/contributing.html#combining-commits) |
|
Noted and squashed. |
|
Thanks a lot! |
jorisvandenbossche
added a commit
that referenced
this pull request
Dec 19, 2015
BUG: force list type for tuples from chunked sql table reads #11522
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11522.