Skip to content

Conversation

terrytangyuan
Copy link
Contributor

The current test for test_to_html_unicode only checks for whether the function works but does not check for its correctness.

@terrytangyuan
Copy link
Contributor Author

On green. Can this be merged?

@jreback jreback added Testing pandas testing functions or related to the test suite Unicode Unicode strings IO HTML read_html, to_html, Styler.apply, Styler.applymap labels Sep 16, 2015
@jreback jreback added this to the 0.17.0 milestone Sep 16, 2015
@jreback
Copy link
Contributor

jreback commented Sep 16, 2015

looks good. will merge soon.

jreback added a commit that referenced this pull request Sep 16, 2015
TST: More thorough test to check correctness of to_html_unicode
@jreback jreback merged commit 0c61168 into pandas-dev:master Sep 16, 2015
@jreback
Copy link
Contributor

jreback commented Sep 16, 2015

thanks!

@terrytangyuan terrytangyuan deleted the tests branch September 16, 2015 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO HTML read_html, to_html, Styler.apply, Styler.applymap Testing pandas testing functions or related to the test suite Unicode Unicode strings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants