-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Closed
Labels
Error ReportingIncorrect or improved errors from pandasIncorrect or improved errors from pandasGroupbyPerformanceMemory or execution speed performanceMemory or execution speed performance
Description
see #7568
nth
is a fair bit slower thanfirst/last
which are calling cython routines. In a case where you don'tdropna
you can simply call the cython aggregation routines- side issue is to move the
group_last_object/group_nth_object
fromalgos.pyx
togenerate_code.py
(simply movegroup_last/group_nth
from thegroupby
template to the same asgroup_count
template, which generates the object dtypes) - trap and reraise an error like
ValueError buffer type mismatch
in the cython trials. This is generated when a built in routine tries to use the cython routines, but the function is not defined (but it SHOULD be defined for all dtypes), so this is a trapped bug (in which case it goes to the python path).
Metadata
Metadata
Assignees
Labels
Error ReportingIncorrect or improved errors from pandasIncorrect or improved errors from pandasGroupbyPerformanceMemory or execution speed performanceMemory or execution speed performance