CI: revert the warning change once IPython updates #31407
Labels
CI
Continuous Integration
Comments
ShaharNaveh
pushed a commit
to ShaharNaveh/pandas
that referenced
this issue
Feb 1, 2020
5 tasks
ShaharNaveh
pushed a commit
to ShaharNaveh/pandas
that referenced
this issue
Feb 22, 2020
|
@charlesdong1991 how will we know when this is ready to address? |
|
i think we can already address this, I just checked the issue ipython/ipython#12102 and seems it has been solved and the new release of ipython came out a couple weeks ago. Pls let me revert the original PR and see if anything breaks. |
1 task
|
@charlesdong1991 some tab completion tests are failing, is that related to this? |
|
Looks like the warning code has been reverted on master for quite some time since 2021-02-02, so appears safe to close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A couple days ago, there was a CI broken caused by the latest jedi release, and back then, made a patch to catch the warning. Ideally, after ipython updates and fixes the deprecated code, then the warning should be removed, and we should be able to revert the change in #31323
FYI, I created an issue on IPython: ipython/ipython#12102
The text was updated successfully, but these errors were encountered: