Skip to content

REF: Move _shallow_copy from SelectionMixin to Window #28938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue Oct 12, 2019 · 1 comment · Fixed by #29427
Closed

REF: Move _shallow_copy from SelectionMixin to Window #28938

jbrockmendel opened this issue Oct 12, 2019 · 1 comment · Fixed by #29427
Labels
Refactor Internal refactoring of code
Milestone
1.0.0

Comments

@jbrockmendel
Copy link
Member

SelectionMixin._shallow_copy is only used by Window/Rolling/... subclasses. Since SelectionMixin is mixed into NDFrame, it would be nice to narrow down the namespace. Thoughts @mroeschke ?
@mroeschke
Copy link
Member

Make sense to me if it's only used by Window/Rolling. Happy to move it there.

@jbrockmendel jbrockmendel added the Refactor Internal refactoring of code label Oct 16, 2019
@jbrockmendel jbrockmendel mentioned this issue Nov 6, 2019
Merged
3 tasks
@jreback jreback added this to the 1.0 milestone Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactor Internal refactoring of code
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

REF: separate out ShallowMixin jbrockmendel/pandas
3 participants
@jreback @jbrockmendel @mroeschke