Skip to content

MAINT: port numpy#13188 for np_datetime simplification #26500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue May 23, 2019 · 2 comments · Fixed by #26516
Closed

MAINT: port numpy#13188 for np_datetime simplification #26500

jbrockmendel opened this issue May 23, 2019 · 2 comments · Fixed by #26516
Labels
Dependencies Required and optional dependencies good first issue Internals Related to non-user accessible pandas implementation
Milestone
0.25.0

Comments

@jbrockmendel
Copy link
Member

our _libs/tslibs/src/np_datetime.c is based off of the numpy version. A recent PR there made a pretty nice simplfication to the relevant code. We should do the same.

https://github.com/numpy/numpy/pull/13188/files
@gfyoung gfyoung added Dependencies Required and optional dependencies good first issue Internals Related to non-user accessible pandas implementation labels May 23, 2019
@xcz011
Copy link
Contributor

xcz011 commented May 23, 2019

If possible, I’d like to contribute this. I may need some help since this is my first contribution. Thanks!

@jbrockmendel
Copy link
Member Author

Great, a PR is welcome. If you're comfortable with C, it's just a matter of making sure we haven't changed anything that would make that patch inapplicable, then copy/paste, with appropriate attribution.

@xcz011 xcz011 mentioned this issue May 24, 2019
Merged
4 tasks
@jreback jreback added this to the 0.25.0 milestone May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Dependencies Required and optional dependencies good first issue Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
0.25.0
Development

Successfully merging a pull request may close this issue.

MAINT: port numpy#13188 for np_datetime simplification
4 participants
@jreback @jbrockmendel @gfyoung @xcz011