Python -00 test is fragile to PATH

[TomAugspurger]

pandas/pandas/tests/test_downstream.py

Line 60 in ab668b0

subprocess.check_call(["python", "-OO", "-c", "import pandas"])

that assumes that first python on the PATH is the one running the tests, which it may not be (e.g. if doing ./venv/bin/python

We should replace python with something like sys.executable.

[WillAyd]

Hmm interesting. Is this causing issues with CI or more of a concern with local configurations?

[TomAugspurger]

Local config: in https://github.com/pandas-dev/pandas-release/blob/master/Makefile#L28 I use a relative path for the python binary, and was confused why this test was failing. That test found a different python on my PATH, which had 0.23.0 installed, so the test failed and I was very confused :)

…

On Tue, Jun 12, 2018 at 1:57 PM, William Ayd ***@***.***> wrote: Hmm interesting. Is this causing issues with CI or more of a concern with local configurations? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#21450 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIkk7CYoZ6g7OT0HUcVmBlnTB1pv1ks5t8A8xgaJpZM4Uk9bh> .

[WillAyd]

Probably have a similar issue with the below:

pandas/pandas/tests/plotting/test_converter.py

Line 30 in ab668b0

call = ['python', '-c', code]

If possible might be a good idea to set up the executable as a shared fixture