Skip to content

COMPAT: windows builds breaking after #13788 #13863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Aug 1, 2016 · 6 comments
Closed

COMPAT: windows builds breaking after #13788 #13863

jreback opened this issue Aug 1, 2016 · 6 comments
Labels
Compat pandas objects compatability with Numpy or Python functions Windows Windows OS
Milestone
0.19.0

Comments

@jreback
Copy link
Contributor

jreback commented Aug 1, 2016

see here

looks like a pointer specification, see #13788
@jreback jreback added Windows Windows OS Compat pandas objects compatability with Numpy or Python functions labels Aug 1, 2016
@jreback jreback added this to the 0.19.0 milestone Aug 1, 2016
@jreback
Copy link
Contributor Author

jreback commented Aug 1, 2016

cc @pijucha
cc @ivannz

@ivannz
Copy link
Contributor

ivannz commented Aug 1, 2016

Sorry, for that. I can make PR fixing this right away.

@ivannz
Copy link
Contributor

ivannz commented Aug 1, 2016 •
edited
Loading

Unfortunately I am able to test the build only on win7 64bit virtual machine with anaconda 4.1.1 and python 2.7.12 using the VC for python2.7. I can't get VS2015 just yet.

@ivannz
Copy link
Contributor

ivannz commented Aug 1, 2016

I tested the build on python 3.5 with VS2015 and on python 2.7 with VS2008 as outlined here and it was successful.

@jreback
Copy link
Contributor Author

jreback commented Aug 1, 2016

we have appveyor CI which does not agree: https://ci.appveyor.com/project/jreback/pandas-465/build/1.0.825

this also fails locally for me as well.

@ivannz
Copy link
Contributor

ivannz commented Aug 1, 2016

I am terribly sorry, I meant the build of the branch for the PR I am currently making.

@ivannz ivannz mentioned this issue Aug 1, 2016
Closed
4 tasks
@jreback jreback closed this as completed in 49243d6 Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions Windows Windows OS
Projects
None yet
Milestone
0.19.0
Development

No branches or pull requests
2 participants
@jreback @ivannz