Support numpy 2.0 in tests #943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
Jun 26, 2024
| "FIRSTPARTY", | ||
| "POST_CORE", | ||
| "LOCALFOLDER", | ||
| ] |
There was a problem hiding this comment.
Do you use a formatting tool for these changes?
There was a problem hiding this comment.
I used VSCode to do the editing, and I have a setting to tell it to auto-format files after saving, so I'm guessing that's what happened.
Will you merge?
twoertwein
approved these changes
Jun 26, 2024
|
Thank you @Dr-Irv ! |
This was referenced Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is now pulling in numpy 2.0, so this removes the numpy deprecated
np.float_and changes it tonp.double, which works with older and newer versions of numpy.In addition, there are a number of other changes where
numpyhas removed certain aliases for dtypes, so removed those from the tests.Set up the CI to use numpy 1.x with python <=3.11, and numpy 2.0 with python=3.12 so both versions of numpy are tested.