Add unit property and as_unit method to DatetimeIndex, TimedeltaIndex and Series.dt
#865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skatsuta
force-pushed
the
add-as-unit-to-datetimeindex-timedeltaindex-series-dt
branch
from
dc1dace to
cd35a2f
Compare
skatsuta
commented
Feb 12, 2024
Comment on lines
-157
to
+159
| _DTRoundingMethodReturnType = TypeVar( | ||
| "_DTRoundingMethodReturnType", | ||
| _DTTimestampTimedeltaReturnType = TypeVar( | ||
| "_DTTimestampTimedeltaReturnType", |
There was a problem hiding this comment.
Rename to a general name to reuse this type var in the return type annotation for as_unit method
3 tasks
skatsuta
force-pushed
the
add-as-unit-to-datetimeindex-timedeltaindex-series-dt
branch
from
cd35a2f to
9120dce
Compare
Dr-Irv
approved these changes
Feb 13, 2024
skatsuta
deleted the
add-as-unit-to-datetimeindex-timedeltaindex-series-dt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return valueAdd
unitproperty andas_unitmethod toDatetimeIndex,TimedeltaIndexandSeries.dt,to add support for the following items in #624:
Note: The addition to
TimelikeOpsis not necessarily needed to add support forSeries.dt, but since it is in the pandas implementation, we should also add it in this stub for consistency.