Skip to content

Conversation

ramvikrams
Copy link
Contributor

@ramvikrams ramvikrams commented Apr 21, 2023

@ramvikrams ramvikrams changed the title GH: 624 - Added dtype_backend to all functions GH: 624 - Added dtype_backend to all read_* functions Apr 21, 2023
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just some re-ordering to do

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found a couple other things

@ramvikrams ramvikrams requested a review from Dr-Irv April 22, 2023 14:49
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Had one question on a test.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ramvikrams

@Dr-Irv Dr-Irv merged commit c67da63 into pandas-dev:main Apr 24, 2023
@ramvikrams ramvikrams deleted the t220 branch April 24, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 2.0 Compatibility Tracker
2 participants