GH - 624: Added dtype arg to read_sql
#649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramvikrams
changed the title
dtype arg to reaf_sqldtype arg to read_sql
twoertwein
approved these changes
Apr 19, 2023
Dr-Irv
requested changes
Apr 20, 2023
Collaborator
Dr-Irv
left a comment
Dr-Irv
left a comment
There was a problem hiding this comment.
Can you do 2 things here:
- Another change to
read_sql()is the introduction of thedtype_backendargument, so can you make that change in this PR? - Can you modify your test to use a different argument for
dtype, e.g., something likedtype={"int_column": float}should work. You may need to experiment with that.
Contributor
Author
Done |
Dr-Irv
requested changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value