gh-624 : Added index parameter to to_dict and added axis argument to Series.add_suffix(), DataFrame.add_suffix(), Series.add_prefix() and DataFrame.add_prefix()

[ramvikrams]

• Closes Version 2.0 Compatibility Tracker #624
• Tests added: Please use assert_type() to assert the type of any return value

I added the parameters, but just a question do we have to add test in these compatibility changes also

[Dr-Irv]

Fix as suggested, and investigate failures in mypy

[Dr-Irv]

I think, but I'm not sure, that the changes I suggested will fix your problems. You have to really understand how typing works to debug what is going on. Make the changes incrementally, and test locally.

[ramvikrams]

I think, but I'm not sure, that the changes I suggested will fix your problems. You have to really understand how typing works to debug what is going on. Make the changes incrementally, and test locally.

Yes now I'll try harder in the all upcoming issues

[Dr-Irv]

Can you also add a set of tests for this, i.e., test index=True and index=False with different values of orient . Test the index arguments of add_prefix() and add_suffix() as well.

When index=False is not allowed, then just do an assert_type() test, surrounded by if TYPE_CHECKING_INVALID_USAGE: with a correct # type: ignore[???] # pyright: ignore[reportGeneralTypeIssues] Idea here is to make sure that from a typing perspective, we have tested that we are rejecting False when it is not allowed.

[Dr-Irv]

thanks @ramvikrams

[ramvikrams]

thanks @ramvikrams

Thanks sir