for #392 #403
Merged
for #392 #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added the tests sir |
Dr-Irv
requested changes
Oct 31, 2022
| @@ -1915,3 +1915,8 @@ def f(s: pd.DataFrame) -> pd.Series: | |||
| return s.mean() | |||
|
|
|||
| check(assert_type(resampler.apply(f), Union[pd.Series, pd.DataFrame]), pd.DataFrame) | |||
|
|
|||
|
|
|||
| def df_accepting_dicts_iterator() -> None: | |||
There was a problem hiding this comment.
Can you add a comment here to reference the original issue, i..e., # GH 392
Dr-Irv
requested changes
Oct 31, 2022
tests/test_frame.py
Outdated
| @@ -1915,3 +1915,8 @@ def f(s: pd.DataFrame) -> pd.Series: | |||
| return s.mean() | |||
|
|
|||
| check(assert_type(resampler.apply(f), Union[pd.Series, pd.DataFrame]), pd.DataFrame) | |||
|
|
|||
|
|
|||
| def df_accepting_dicts_iterator() -> None: # GH 392 | |||
There was a problem hiding this comment.
Please put this comment on its own line (see elsewhere for examples of this)
You also have extra spaces on the two lines above. Make sure you run black on your files before you commit.
There was a problem hiding this comment.
Done and ran black
Dr-Irv
requested changes
Oct 31, 2022
tests/test_frame.py
Outdated
| def df_accepting_dicts_iterator() -> None: | ||
| # GH 392 | ||
| data = [{"a": 1, "b": 2}, {"a": 3, "b": 5}] | ||
| p = pd.DataFrame(iter(data)) |
There was a problem hiding this comment.
One more thing. Can you change this last line to:
check(assert_type(pd.DataFrame(iter(data)), pd.DataFrame), pd.DataFrame)
Dr-Irv
requested changes
Oct 31, 2022
tests/test_frame.py
Outdated
| @@ -1915,3 +1915,9 @@ def f(s: pd.DataFrame) -> pd.Series: | |||
| return s.mean() | |||
|
|
|||
| check(assert_type(resampler.apply(f), Union[pd.Series, pd.DataFrame]), pd.DataFrame) | |||
|
|
|||
|
|
|||
| def df_accepting_dicts_iterator() -> None: | |||
There was a problem hiding this comment.
You have to make sure you run black before committing. You have an extra space at the end of this line.
Welcome sir you helped a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added dict
assert_type()to assert the type of any return value