-
-
Notifications
You must be signed in to change notification settings - Fork 144
Remove deprecated arguments and functions #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,7 @@ from pandas._typing import ( | |
|
||
def read_xml( | ||
path_or_buffer: FilePath | ReadBuffer[bytes] | ReadBuffer[str], | ||
*, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not clear why you added this?? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We deprecated passing positional arguments to read_xml in 1.4 Deprecated passing arguments as positional for read_xml() other than path_or_buffer (GH45133) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK, the docs don't say anything about that, so maybe the docs should be updated as well. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we are not mentioning positional deprecations in the docs |
||
xpath: str = ..., | ||
namespaces: dict[str, str] | None = ..., | ||
elems_only: bool = ..., | ||
|
Uh oh!
There was an error while loading. Please reload this page.