Skip to content

Remove deprecated behaviors #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Remove deprecated behaviors #268

merged 2 commits into from
Sep 5, 2022

Conversation

twoertwein
Copy link
Member

No description provided.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the changes, but just merged in changes on read_csv() that is now in a different file, so you'll have to move those changes to that file (readers.pyi)

@twoertwein
Copy link
Member Author

I'm fine with the changes, but just merged in changes on read_csv() that is now in a different file, so you'll have to move those changes to that file (readers.pyi)

I believe I rebased (and forced pushed) while you were reviewing this PR - should already be compatible with main.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @twoertwein

I'll merge this, but your first commit had changes for read_csv(), and the final version does not, so you may want to look at that

@Dr-Irv Dr-Irv merged commit 3dc62dd into pandas-dev:main Sep 5, 2022
@twoertwein
Copy link
Member Author

thanks @twoertwein

I'll merge this, but your first commit had changes for read_csv(), and the final version does not, so you may want to look at that

@bashtage already removed prefix and squeeze in his PR so all those changes disappeared after rebasing.

@twoertwein twoertwein deleted the future branch September 21, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants