Skip to content

Conversation

bashtage
Copy link
Contributor

Synchronize to and read XML to upstream

Synchronize to and read XML to upstream
@bashtage
Copy link
Contributor Author

No tests because lxml is not in the environment. Not sure if there is a desire to expand the install.

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Aug 18, 2022

No tests because lxml is not in the environment. Not sure if there is a desire to expand the install.

It would just have to go in the section in pyproject.toml under [tool.poetry.dev-dependencies] so wouldn't be an installation requirement for the stubs, just for testing, and I think we should do that.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bashtage

@Dr-Irv Dr-Irv merged commit 417c3d0 into pandas-dev:main Aug 22, 2022
@bashtage bashtage deleted the io-xml branch August 23, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants