feat(array): #624 accumulate #1400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmp0xff
force-pushed
the
feature/cmp0xff/624-extension-array-accumulate
branch
from
79a77ac to
309fdf4
Compare
loicdiridollou
approved these changes
Oct 2, 2025
Dr-Irv
requested changes
Oct 3, 2025
tests/series/test_properties.py
Outdated
| assert_type( | ||
| pd.Series([1], dtype="category").array, | ||
| pd.Categorical, | ||
| cast("Series[Int64Dtype]", Series([1, NA], dtype="Int64")).array, |
Collaborator
There was a problem hiding this comment.
I think we should not have a test like this for 2 reasons:
- It encourages the use of
Series[Int64Dtype]and I just don't think we would introduce that. Also, thenInt64Dtypeshould really be inS1 - We can have a test with
dtype="Int64", but then the results will just be anExtensionArrayfor now, and if someone wants the real type, they can cast the result.
Comment on lines
471
to
473
| def __get__( | ||
| self, instance: IndexOpsMixin[Int64Dtype], owner: type[IndexOpsMixin] | ||
| ) -> IntegerArray: ... |
Collaborator
There was a problem hiding this comment.
I don't think this should exist because Int64Dtype is in S1, and I don't want to introduce that now, because it will open up a whole set of new issues.
Collaborator
I don't think we need to create a new type for that. The extension array stuff isn't widely used. |
Dr-Irv
approved these changes
Oct 3, 2025
cmp0xff
commented
Oct 3, 2025
Contributor
Author
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
Series[Int64Dtype] removed
tests/series/test_properties.py
Outdated
| assert_type( | ||
| pd.Series([1], dtype="category").array, | ||
| pd.Categorical, | ||
| cast("Series[Int64Dtype]", Series([1, NA], dtype="Int64")).array, |
Comment on lines
471
to
473
| def __get__( | ||
| self, instance: IndexOpsMixin[Int64Dtype], owner: type[IndexOpsMixin] | ||
| ) -> IntegerArray: ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cumsum, cumprod, cummin and cummax to the ExtensionArray interface via _accumulate(partially resolving it)