Pandas and Matplotlib Dependency in the Stubs Package

[lovetheguitar]

Could you please remove pandas and matplotlib from the dependencies of the pandas-stubs package.

Why would you have a separate stubs package and then depend on the main package and even matplotlib?

This package was super slim until 6 days ago: https://github.com/VirtusLab/pandas-stubs/blob/master/setup.py#L38-L40

Thank you.

[Dr-Irv]

The previous stubs were installed on top of the pandas installation, so you had to have pandas installed. Now pandas-stubs is installed as a separate package which is separate from the pandas installation.

With respect to matplotlib, the stubs import matplotlib, so it's not clear that they would work without matplotlib installed.

The purpose of these stubs is to sit alongside pandas. I think you have to include the dependencies, but if you can prove they would work without pandas or matplotlib installed, then we could make a change.

[twoertwein]

With respect to matplotlib, the stubs import matplotlib, so it's not clear that they would work without matplotlib installed.

Most of matplotlib is not annotated. I think the matplotlib type used the most is Axes which unfortunately resolves to Any.

from matplotlib.axes import Axes

reveal_type(Axes)  # mypy: any, pyright: Unknown

If the goal of pandas-stubs is to eventually be part of typeshed and be recommeneded by mypy, I think pandas-stubs cannot depend on any actual code (and only contain pyi files).

Should probably keep matplotlib at least on the CI: pyright would otherwise complain that it cannot find all the matplotlib imports (and matplotlib might add annotations in the future).

[Dr-Irv]

Most of matplotlib is not annotated. I think the matplotlib type used the most is Axes which unfortunately resolves to Any.

matplotlib does have annotations that are shipped with VS Code.

from matplotlib.axes import Axes

reveal_type(Axes)  # mypy: any, pyright: Unknown

In the above example, within VS Code, you will get Type[Axes] on the reveal_type()

If the goal of pandas-stubs is to eventually be part of typeshed and be recommeneded by mypy, I think pandas-stubs cannot depend on any actual code (and only contain pyi files).

I'm not sure that the goal is to make pandas-stubs part of typeshed, although I could see that happening in the future.

[twoertwein]

matplotlib does have annotations that are shipped with VS Code.

Thank you, I didn't know that! If they have a standalone stub package, pandas-stubs (and pandas) should install that at least for the CI. mypy&pyright infer Axes on the pandas CI as Any/Unknown.

[Dr-Irv]

matplotlib does have annotations that are shipped with VS Code.

Thank you, I didn't know that! If they have a standalone stub package, pandas-stubs (and pandas) should install that at least for the CI. mypy&pyright infer Axes on the pandas CI as Any/Unknown.

To clarify, the matplotlib annotations are maintained by Microsoft in https://github.com/microsoft/python-type-stubs, and then Microsoft merges those stubs into the VS Code distribution.

[Dr-Irv]

closed via #66