-
-
Notifications
You must be signed in to change notification settings - Fork 152
Open
Labels
Description
When we do a merge, we run pyright using the strict option. Current statistics on the types of errors found:
reportUnknownMemberType 2387
reportUnknownParameterType 2112
reportMissingTypeArgument 1560
reportMissingParameterType 1247
reportUnknownArgumentType 613
reportUnknownVariableType 428
reportUnusedVariable 88
reportUnknownLambdaType 58
reportUnusedExpression 41
reportPrivateUsage 15
reportMissingTypeStubs 7
Can be output by running poe test pyright_strict
There are 8556 errors, and 3541 of them are in the stubs themselves. Rest are reported from the tests (but may be due to the stubs).
FYI for @MarcoGorelli
Some simple things that would help:
- Change references to
npt.NDArrayto benpt.NDArray[Any, Any] - Change
argsandkwargs(see question: how to type compatibility-onlyargs/kwargs? #1168) in all stubs file - Maybe change references from plain
SeriestoUnknownSeriesand change from plainIndextoUnknownIndexin all stubs file
MarcoGorelli, yangdanny97 and cmp0xff