Allow usage of Pylint via stdin #831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpanarin
force-pushed
the
pylint_from_stdin
branch
2 times, most recently
from
159a7b8 to
5a2c8df
Compare
|
This closes #796 |
|
@ccordoba12 @goanpeca Thanks! |
Mimics flake8 stdin usage. This makes it possible for pylint to run on unsaved files works on pylint>=2.5.0 I didn't notice a performance degradation in terms of running pylint itself. Of course, there *is* a performance hit overall, as pylint will be run on every change, and it can be fairly slow
mpanarin
force-pushed
the
pylint_from_stdin
branch
from
5a2c8df to
bd1df91
Compare
|
Can this be merged? It's been 2 month already ( |
delta003
approved these changes
Sep 9, 2020
|
We need to merge first #842 to verify that tests pass in this PR before merging. |
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mimics
flake8stdin usage.This makes it possible for pylint to run on unsaved files
works on
pylint>=2.5.0and python 3+I didn't notice a performance degradation in terms of running pylint itself.
Of course, there is a performance hit overall, as pylint will be run on every
change, and it can be fairly slow but there was a bunch of requests for that in emacs-lsp
community.
Disabled by default
ex. @chama-chomo
Fixes #796