Add Lint Trigger #393
Add Lint Trigger #393
Conversation
Pass a "trigger" string to the `pyls_lint` hook. This allows linter hook implementations to decide whether to run or not, based on what triggered linting. Useful for linters that are expensive to run, so we don't want to run them on-change. Since hook arguments are passed by keyword, this requires no changes to existing local linter hook implementations.
|
Thanks for your interest in palantir/python-language-server, @drmathochist! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
There was a problem hiding this comment.
Sorry it took me so long to get to this! Generally I like the approach, but I think the trigger strings should a) be called triggered_by, and b) be part of the hookspecs.py file in some sort of enum-style object (see the lsp.py file).
That way they're more obviously part of the hook-spec API.
|
Going to close this since #385 adds a "saved" argument to the lint hook. For expensive linters moving forwards I suggest we add an async_lint hook that passes a callback function. This way the linter can take as long as it likes, and even call multiple times per request. |
Pass a "trigger" string to the
pyls_linthook. This allows linterhook implementations to decide whether to run or not, based on what
triggered linting. Useful for linters that are expensive to run,
so we don't want to run them on-change.
Since hook arguments are passed by keyword, this requires no changes
to existing local linter hook implementations.