Update performance.rst #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seemingly there is no longer IDataPoint to extend. :( Found as I was trying to implement the suggestions
|
There is |
|
As it turns out you can't extend data point - it's a struct. So it really must suggest extending IDataPointProvider |
|
Good point on the working. Feel free to force-push a change to that effect in this branch. I don't think we have any particular contribution requirements, so I'll merge this after a couple of days to give other people a change to provide commentary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seemingly there is no longer IDataPoint to extend. :(
Found as I was trying to implement the suggestions