Skip to content

Collect timesync status in inventory #8603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

Collect timesync status in inventory #8603

merged 1 commit into from
Jul 22, 2025

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Jul 15, 2025 •
edited
Loading

Depends on #8597

Queries the NTP admin server for both internal and boundary NTP zones. Stores a simplified
representation of "who was queried, and is time synced for this service".

This information will be used in #8616

Fixes #8546

@smklein smklein force-pushed the inventory-collect-timesync branch from d5d874b to 75b39c7 Compare July 16, 2025 22:16
@smklein smklein force-pushed the inventory-collect-timesync branch 2 times, most recently from 30a86a1 to 2ded09d Compare July 17, 2025 22:27
@smklein smklein force-pushed the ntp-admin-use branch 2 times, most recently from 6b3f414 to c514b3f Compare July 17, 2025 23:04
@smklein smklein force-pushed the inventory-collect-timesync branch 2 times, most recently from e784b52 to 568a4db Compare July 18, 2025 00:08
Base automatically changed from ntp-admin-use to main July 18, 2025 15:47
@smklein smklein marked this pull request as ready for review July 18, 2025 15:47
@smklein smklein force-pushed the inventory-collect-timesync branch from 568a4db to 71e2738 Compare July 18, 2025 15:49
@smklein smklein changed the title Trying to collect timesync status in inventory Collect timesync status in inventory Jul 18, 2025
smklein
smklein commented Jul 18, 2025
View reviewed changes
This was referenced Jul 18, 2025
Closed
Merged
smklein
smklein commented Jul 18, 2025
View reviewed changes
@smklein smklein force-pushed the inventory-collect-timesync branch from 71e2738 to 91d9377 Compare July 18, 2025 20:05
andrewjstone
andrewjstone approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@andrewjstone andrewjstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@smklein smklein force-pushed the inventory-collect-timesync branch 3 times, most recently from c16686f to bea6e02 Compare July 21, 2025 19:15
@smklein smklein enabled auto-merge (squash) July 21, 2025 19:15
@smklein smklein force-pushed the inventory-collect-timesync branch from bea6e02 to 5f2c4dd Compare July 21, 2025 21:39
@smklein smklein merged commit cc1aba6 into main Jul 22, 2025
17 checks passed
@smklein smklein deleted the inventory-collect-timesync branch July 22, 2025 02:36
smklein added a commit that referenced this pull request Jul 23, 2025
@smklein
Use timesync status to decide when to upgrade boundary NTP zones (#8616)
9e642c9 
Depends on #8603

Prevent the planner from tearing down boundary NTP zones when we are not
at expected "BOUNDARY_NTP_REDUNDANCY" synchronized zones.

Adds a test which demonstrates that we'll only drop "one zone" below
redundancy during an upgrade, and never
further than that.

Fixes #8547
@jgallagher jgallagher mentioned this pull request Jul 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewjstone andrewjstone andrewjstone approved these changes

@jgallagher jgallagher jgallagher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

want boundary NTP sync status in inventory
3 participants
@smklein @andrewjstone @jgallagher