convert route endpoints to new lookup API #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 tasks
Collaborator
Author
|
I think this is ready to review but it's blocked on #798. |
david-crespo
approved these changes
Mar 31, 2022
Contributor
david-crespo
left a comment
david-crespo
left a comment
There was a problem hiding this comment.
Looks great. Kind of funny that it's more code, but it's very nice code. And deleting vpc_router_lookup_by_path eventually will offset it.
Collaborator
Author
|
Yeah, I'd forgotten to remove |
Contributor
never mind about it being more code! |
Contributor
|
This is just sooo damn good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the "route" endpoints to use the new lookup API.
As part of this, I changed the
router_idcolumn on therouter_routetable to be calledvpc_router_id, so that we can maintain the expectation that the foreign key id is derivable from the foreign table name. #798 depends on this.