Thing-flinger: Allow deployment to single node #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smklein
approved these changes
Mar 30, 2022
`sled-agent-overlay-files` generates secret shares for rack unlock in a multinode cluster. However, rack secrets and their resulting shares can only be created for clusters with 2 or more nodes. As we want to be able to use thing-flinger to deploy to a single node system, we skip generation of the secret if there is only one deployment server. This works because the sled-agent bootstrap code runs in single node mode if no share is found. Without this change, the user would get a `vsss_rs::Error::SharingMinThreshold` error when running `thing-flinger overlay`.
andrewjstone
force-pushed
the
thing-flinger-overlay-fix
branch
from
50c651f to
036c2b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sled-agent-overlay-filesgenerates secret shares for rack unlock in amultinode cluster. However, rack secrets and their resulting shares can only be
created for clusters with 2 or more nodes. As we want to be able to use
thing-flinger to deploy to a single node system, we skip generation of the
secret if there is only one deployment server. This works because the sled-agent
bootstrap code runs in single node mode if no share is found.
Without this change, the user would get a
vsss_rs::Error::SharingMinThresholderror when running
thing-flinger overlay.