Skip to content

MGS: Finish extracting SP communications to its own crate #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2022
Merged

MGS: Finish extracting SP communications to its own crate #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95d8c48
MGS: Finish extracting SP communications to its own crate
jgallagher Mar 17, 2022
d6ef524
Address feedback on #777
jgallagher Mar 28, 2022
93b27cd
MGS: Parse packet version before trying to deserialize
jgallagher Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions gateway-messages/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,12 @@ pub struct IgnitionState {
pub flags: IgnitionFlags,
}

impl IgnitionState {
pub fn is_powered_on(self) -> bool {
self.flags.intersects(IgnitionFlags::POWER)
}
}

bitflags! {
#[derive(Default, SerializedSize, Serialize, Deserialize)]
pub struct IgnitionFlags: u8 {
Expand Down Expand Up @@ -305,6 +311,7 @@ impl fmt::Debug for SpComponent {

/// Error type returned from `TryFrom<&str> for SpComponent` if the provided ID
/// is too long.
#[derive(Debug)]
pub struct SpComponentIdTooLong;

impl TryFrom<&str> for SpComponent {
Expand Down
1 change: 1 addition & 0 deletions gateway-sp-comms/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,5 @@ version = "1.16"
features = [ "full" ]

[dev-dependencies]
once_cell = "1.9"
omicron-test-utils = { path = "../test-utils" }
Loading