Skip to content

Run sled-agent in its own project #5324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Run sled-agent in its own project #5324

wants to merge 1 commit into from

Conversation

citrus-it
Copy link
Contributor

Fixes #5321; also requires oxidecomputer/helios#146

@citrus-it citrus-it mentioned this pull request Mar 26, 2024
Open
@citrus-it citrus-it requested review from jgallagher and jclulow March 26, 2024 10:49
@citrus-it citrus-it requested a review from rmustacc April 4, 2024 17:17
rmustacc
rmustacc reviewed Apr 17, 2024
View reviewed changes
Copy link

@rmustacc rmustacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are we expecting to put the project's constraints? That is, I think some of this is to make sure that the project can't use up all the contracts. Is that inherent in the project's defaults somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmustacc rmustacc rmustacc left review comments

@jgallagher jgallagher Awaiting requested review from jgallagher

@jclulow jclulow Awaiting requested review from jclulow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sled-agent should not be part of the "system" contract
2 participants
@citrus-it @rmustacc