cockroachdb: Fix download script for illumos #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously copying the new version into `cockroachdb/cockroachdb-<newver>` instead of replacing the `cockroachdb` directory.
david-crespo
approved these changes
Dec 2, 2021
|
Thanks Tess, all the more reason why that "DB version-check" PR is extremely useful |
|
Sorry for the bug and thanks for fixing! I can't remember for sure, but I think part of what I was going for originally was that you could have multiple different versions locally. This would make it easy to switch which version you were testing by just changing your PATH. It seems like this wouldn't work any more. Of course, it wasn't really working before, so we can punt on this until it becomes more important. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously copying the new version into
cockroachdb/cockroachdb-<newver>instead of replacingthe
cockroachdbdirectory.Fixes #475