Skip to content

Conversation

pfmooney
Copy link
Contributor

As I pulled in the oximeter dependency for integration in propolis-server, I saw it building a bunch of stuff (including an entirely separate version of propolis-server) through dependencies which looked as if they are unneeded.

@pfmooney pfmooney requested a review from bnaecker November 30, 2021 20:14
Copy link
Collaborator

@bnaecker bnaecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these strays, LGTM.

@pfmooney pfmooney enabled auto-merge (squash) November 30, 2021 21:15
@davepacheco davepacheco mentioned this pull request Dec 1, 2021
@pfmooney pfmooney merged commit f4fd425 into oxidecomputer:main Dec 1, 2021
@pfmooney pfmooney deleted the prune-oximeter-deps branch December 1, 2021 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants