Skip to content

Use NameOrId in InstanceCreate.external_ips #3992

@david-crespo

Description

@david-crespo

#3985 (comment)

I think the main reason it was name only was that the name "default" was significant, and now it isn't.

/// The external IP addresses provided to this instance.
///
/// By default, all instances have outbound connectivity, but no inbound
/// connectivity. These external addresses can be used to provide a fixed,
/// known IP address for making inbound connections to the instance.
#[serde(default)]
pub external_ips: Vec<ExternalIpCreate>,

/// Parameters for creating an external IP address for instances.
#[derive(Clone, Debug, Deserialize, Serialize, JsonSchema)]
#[serde(tag = "type", rename_all = "snake_case")]
pub enum ExternalIpCreate {
/// An IP address providing both inbound and outbound access. The address is
/// automatically-assigned from the provided IP Pool, or all available pools
/// if not specified.
Ephemeral { pool_name: Option<Name> },
// TODO: Add floating IPs: https://github.com/oxidecomputer/omicron/issues/1334
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    apiRelated to the API.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions