make mg-admin and ddm-admin APIs versioned #558
Merged
+117
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
26 tasks
|
Need to figure out what to do with the openapi job. |
Created using spr 1.3.6-beta.1
|
@rcgoodfellow would need to remove 
|
|
Hmm, not sure why test-ddm-trio and quartet are failing here -- there shouldn't be any functional changes in this PR. |
rcgoodfellow
reviewed
Oct 2, 2025
| .unwrap(); | ||
|
|
||
| match server.start().await { | ||
| match server.start() { |
There was a problem hiding this comment.
I believe dropping the await is what's causing the test failures. The logs show the "unexpected server exit line". This code expects to wait on the API server, which never really returns.
Probably want something like this
match server.start().expect("failed to start API server").await {
Done |
rcgoodfellow
reviewed
Oct 2, 2025
|
|
||
| Ok(tokio::spawn(async move { | ||
| match server.start().await { | ||
| match server.start() { |
There was a problem hiding this comment.
This also needs to be something like
match server.start().expect("failed to start API server").awaitCreated using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/make-mg-admin-and-ddm-admin-apis-versioned
branch
sunshowers
added a commit
to oxidecomputer/dendrite
that referenced
this pull request
Oct 8, 2025
Last part of Dendrite work for oxidecomputer/omicron#8922. Also remove the dpd-openapi buildomat job that's no longer used since Dendrite is now open source. This change mirrors oxidecomputer/maghemite#558.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last part of oxidecomputer/omicron#8922 for Maghemite: make the admin APIs versioned. Also remove the
openapibuildomat job, since it's a remnant from when maghemite was a private repo (Omicron stopped using it in oxidecomputer/omicron#5271).See the readme within https://github.com/oxidecomputer/dropshot-api-manager for instructions.