Skip to content

Conversation

@davepacheco
Copy link
Collaborator

@davepacheco davepacheco commented Jan 9, 2023

I felt like handler.rs was getting a bit big and full of unrelated stuff. Here I'm separating the extractors into a submodule with the eventual intent on putting different ones into different files within extractors. This involved moving some functions used by both handler.rs and the new extractor module into schema_util.rs (analogous to http_util.rs).

I believe nothing has changed in this PR except for moving code from one file to another and adjusting imports / "mod" statements.

This depends on #553 -- will update the base branch once that one lands and I'll keep this in "draft" for the meantime.

@davepacheco davepacheco requested a review from ahl January 9, 2023 21:59
Base automatically changed from style-update to main January 9, 2023 22:33
@davepacheco
Copy link
Collaborator Author

Sorry for the force push and general noise.

@davepacheco davepacheco marked this pull request as ready for review January 10, 2023 00:07
Copy link
Collaborator

@ahl ahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this reorganization. I said "oooh" aloud when I saw that extractor was its own mod--like it a lot.

api_description.rs has a bunch of j2oas_ prefixed functions; would those make sense to move into schema_util.rs? No or Not now are fine answers.

@davepacheco
Copy link
Collaborator Author

Thanks for the review.

api_description.rs has a bunch of j2oas_ prefixed functions; would those make sense to move into schema_util.rs? No or Not now are fine answers.

That looks like a good idea. I will do it in a follow-up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants