Feature/add boto3 sqs instrumentation #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxeye-yuval
reviewed
May 3, 2022
| # limitations under the License. | ||
| from typing import Collection | ||
|
|
||
| _instruments: Collection[str] = ("boto3 >= 1.21.46",) |
There was a problem hiding this comment.
wouldn't this support older versions?
Owner
Author
There was a problem hiding this comment.
I copied the one from boto3
oxeye-yuval
reviewed
May 3, 2022
| retval = super( | ||
| Boto3SQSInstrumentor.ContextableList, self | ||
| ).__getitem__(*args, **kwargs) | ||
| if isinstance(retval, dict): |
oxeye-yuval
reviewed
May 3, 2022
| self._did_decorate = False | ||
|
|
||
| def _instrument(self, **kwargs: Dict[str, Any]) -> None: | ||
| self._did_decorate: bool = False |
There was a problem hiding this comment.
why not use the is_instrumented_by_opentelemetry function?
Owner
Author
There was a problem hiding this comment.
is_instrumented_by_opentelemetry defines a different thing. From the code, its basically a switch that prevents calling instrument twice. self._did_decorate defines if the functions of botocore.client.SQS are wrapped (which is not necessarily true because by calling instrument without calling boto3.client("sqs") these functions will not be wrapped)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.