Skip to content

Conversation

@yougotwill
Copy link
Contributor

@yougotwill yougotwill commented Aug 14, 2023

We can't add new arguments to the getUserInfo and setUserInfo functions because it would break migrations

Edit: I've realised it's probably best to only merge this once I'm done integrating disappearing messages so will keep updating this branch.

We can't add new arguments to the getUserInfo and setUserInfo functions because it would break migrations
@jagerman
Copy link
Member

Or are you talking about making the function name more explicit like "setNoteToSelfExpiry"? Audric and I chatted about this yesterday and are trying to keep the wrapper method signatures as close to the original libsession functions as possible

Yeah, this. The C++ API function is set_nts_expiry.

@jagerman
Copy link
Member

Where nts = note to self but without being Java.

@yougotwill yougotwill changed the title feat: updated the user profile wrapper to use setExpiry and getExpiry [DO NOT MERGE] feat: updated the user profile wrapper to use setExpiry and getExpiry Aug 15, 2023
@yougotwill
Copy link
Contributor Author

@jagerman That makes sense! I didn't pick up on the nts will update to make the names more explicit. Thanks!

@yougotwill yougotwill changed the title [DO NOT MERGE] feat: updated the user profile wrapper to use setExpiry and getExpiry [DO NOT MERGE] feat: disappearing messages support Aug 15, 2023
@yougotwill yougotwill changed the title [DO NOT MERGE] feat: disappearing messages support feat: v0.3.0 Disappearing Messages support Oct 2, 2023
@yougotwill
Copy link
Contributor Author

This PR includes all code changes required for Disappearing Messages V2 to work on Session Desktop. Since it changes some existing function signatures we have done a minor version bump

wrapResult converts the callable info for us
since we asset the object before
added legacy type for now, will remove later
merge function now returns good hashes
@Bilb Bilb merged commit 003fe5a into oxen-io:main Oct 18, 2023
mpretty-cyro pushed a commit to mpretty-cyro/libsession-util-nodejs that referenced this pull request Feb 23, 2025
fix: bump to 0.4.13 & expose supplement bool for group member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants