Skip to content

Conversation

@airween
Copy link
Member

@airween airween commented Jul 2, 2025

what

This PR removes an unused condition from msc_status_engin.c if the target is DARWIN.

why

In one of a previous commit we removed some unused variables, but it seems like it's still in use.

Unfortunately this was not revealed because that part is only used if the target is DARWIN.

references

Thanks @Greentears.

@airween airween added the 2.x Related to ModSecurity version 2.x label Jul 2, 2025
@airween airween requested a review from fzipi July 2, 2025 20:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 2, 2025

@airween airween requested a review from theseion July 2, 2025 20:18
@theseion
Copy link
Collaborator

theseion commented Jul 3, 2025

This is the commit where variable was removed.

@airween
Copy link
Member Author

airween commented Jul 3, 2025

This is the commit where variable was removed.

I think I wrote the same in my initial commit:

In one of a previous commit we removed some unused variables, but it seems like it's still in use.

😃

Btw thanks for the reviewing!

@airween airween merged commit a4ea4e6 into owasp-modsecurity:v2/master Jul 4, 2025
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.x Related to ModSecurity version 2.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants