Read fuzzy hash db on init #1339
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're re-opening this file with every invocation, let's close our sanity check fd.
|
This also obviates #1332, so we can nix that one if this is worthwhile. |
Instead of reading the fuzzy db on every invocation, read and store the db contents during initialization and store the contents in memory. The only significant behavior change here is that a change in db contents now (obviously) requires a daemon restart, as no API is provided to flush the list of ssdeep chunks.
p0pr0ck5
force-pushed
the
fuzzy_read_init
branch
from
b5c355b to
578ea98
Compare
|
(re-did this to insert elements to the tail of the list upon initialization, so that the file contents are processed top-down during execution, matching the existing behavior). |
|
@p0pr0ck5 Hello. |
|
No, this PR is not about a memory leak. This just removes the need to re-read the fuzzy hash db from disk on every invocation. Your noted issue is unrelated to this PR. |
|
Pull request is currently under our buildbots - http://www.modsecurity.org/developers/buildbot/waterfall |
|
Thanks @p0pr0ck5 -- merged ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of reading the fuzzy db on every invocation, read and store
the db contents during initialization and store the contents in memory.
The only significant behavior change here is that a change in db contents
now (obviously) requires a daemon restart, as no API is provided to
flush the list of ssdeep chunks.