Skip to content

Make the docker image more usable #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2020
Merged

Make the docker image more usable #737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7c1466
Fix copying phpstan config files into docker image
bartv2 Aug 16, 2020
d33866b
Speedup composer install in docker image build
bartv2 Aug 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
!/benchmarks/
!/composer.json
!/phpunit.xml.*
!/phpstan.neon.*
!/phpstan*.neon
Copy link
Contributor

@mcg-web mcg-web Aug 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Copy link
Contributor

@murtukov murtukov Aug 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcg-web I think because i renamed the phpstan.neon.dist long time ago

Copy link
Contributor Author

@bartv2 bartv2 Aug 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the name changed and the config wasn't included

Copy link
Contributor

@mcg-web mcg-web Aug 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok nice, thank you!

!/.php_cs.*
!/phpbench.json
6 changes: 5 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ FROM scratch AS test_source
COPY benchmarks/ benchmarks/
COPY src/ /src/
COPY tests/ /tests/
COPY phpunit.xml.* phpstan.neon.* .php_cs.* phpbench.json /
COPY phpunit.xml.* phpstan*.neon .php_cs.* phpbench.json /
Copy link
Contributor

@mcg-web mcg-web Aug 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?


FROM alpine:3.9

Expand All @@ -28,9 +28,13 @@ RUN set -eu; \
php-xml \
php-dom \
php-pdo \
php-curl \
; ln -s /usr/bin/php7 /usr/bin/php

COPY --from=composer:latest /usr/bin/composer /usr/bin/composer
# install Symfony Flex globally to speed up download of Composer packages (parallelized prefetching)
RUN set -eux; \
composer global require "symfony/flex" --prefer-dist --no-progress --no-suggest --classmap-authoritative;

WORKDIR /opt/test

Expand Down