Skip to content

Set the current user as the owner of the SP #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Set the current user as the owner of the SP #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
822683a
Set the current user as the owner of the SP
Jan 31, 2023
6950403
Merge branch 'master' into azuread-current-user-as-owner
Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions azure/terraform/infra/credentials.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
data "azuread_client_config" "current" {}

# Add an application, a service principal, and a password for the service principal
# This single service principal have access to:
# - Metaflow's storage container
Expand All @@ -6,10 +8,12 @@
# E.g. an end user needs to be able to access Metaflow storage AND submit jobs to AKS (possibly)
resource "azuread_application" "service_principal_application" {
display_name = var.service_principal_name
owners = [data.azuread_client_config.current.object_id]
}

resource "azuread_service_principal" "service_principal" {
application_id = azuread_application.service_principal_application.application_id
owners = [data.azuread_client_config.current.object_id]
}

# This will be used as a AZURE_CLIENT_SECRET in Metaflow's AKS workloads
Expand Down