Introduce a RequiresExternalTool test tag
#10947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10947 +/- ##
============================================
- Coverage 57.58% 57.53% -0.06%
+ Complexity 1705 1703 -2
============================================
Files 346 346
Lines 12833 12833
Branches 1212 1212
============================================
- Hits 7390 7383 -7
- Misses 4978 4985 +7
Partials 465 465
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Extract several classes as separate test fixtures for a better overview and to allow code sharing. As part of that, - get rid of the "org.ossreviewtoolkit.scanner.scanners" package in tests as no such package exists in the "main" source set, - combine two `createScanner()` functions (which requires a minor change to some expected results), - move `MultipleScannersTest` to the "test" source set as it now really is a non-functional test in the sense that it does not depend on a VCS tool for provenance resolution anymore. Note that the "test" source set is automatically configured to depend on the "testFixtures" source set of the same module [1], so only the custom "funTest" source set needs to have the dependency added. [1]: https://github.com/gradle/gradle/blob/v9.1.0/platforms/jvm/plugins-jvm-test-fixtures/src/main/java/org/gradle/api/plugins/JavaTestFixturesPlugin.java#L92-L95 Signed-off-by: Sebastian Schuberth <[email protected]>
mnonnenmacher
requested changes
Oct 7, 2025
This will ease running only these test in an environment that provides the required tools. Unit tests are not tagged as they by definition should not depend on external tools. Note that this does not require to add another `Tag` class because the whole spec is tagged via an annotation that takes a string instead [1]. [1]: https://kotest.io/docs/framework/tags.html#tagging-a-spec Signed-off-by: Sebastian Schuberth <[email protected]>
The tag just disabled a case in `DefaultNestedProvenanceResolverFunTest`. Explicitly disable the case instead with a dedicated comment about the bug. Signed-off-by: Sebastian Schuberth <[email protected]>
mnonnenmacher
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.