Skip to content

Final prelim update #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2021
Merged

Final prelim update #992

merged 2 commits into from
Aug 12, 2021

Conversation

@nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Aug 12, 2021

This contains the final prelim worlds, and a couple small patches that:

  1. Fixes the region detection event to output the correct type.
  2. Adds logging information when finish is manually triggered.

Nate Koenig added 2 commits August 12, 2021 07:56
Fix region events
40ad63a 
Signed-off-by: Nate Koenig <[email protected]>
Finals prelim worlds
716a56f 
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested a review from iche033 August 12, 2021 16:01
iche033
iche033 approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@nkoenig nkoenig merged commit de39df5 into final_event Aug 12, 2021
@nkoenig nkoenig deleted the final_prelim_update branch September 27, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@iche033 iche033 iche033 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nkoenig @mjcarroll @iche033