Skip to content

Conversation

acschang
Copy link
Contributor

@acschang acschang commented Jul 5, 2021

This PR includes a new node to decimate team cloud data by adjusting leaf node size in the PCL library filters. Data is incrementally decimated to prevent submitted clouds having over 600,000 points to exceed the protobuf limits of Ignition transport resulting in the pointcloud being truncated. The original size of the pointcloud prior to decimation is passed to the mapping server.

The node is added to the common launch file for mapping server relays and the relevant PCL dependencies are added to the requisite Dockerfiles.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker image built fine. I tested republishing point clouds from one of the robots to the /cloud topic and verified that the point clouds are downsampled in the cloud_throttled_downsampled topic

@acschang acschang marked this pull request as draft July 6, 2021 22:56
@rsawtell
Copy link

rsawtell commented Jul 7, 2021

To clarify, this can potentially change the size of pointclouds (eg lidar scans etc.) received by solutions in a fully dynamic way such that anything that expects a specific formatting of the pointcloud would break (ie: assuming an rgbd sensor always has 640x480 resolution) and that this happens when all the scans over all robots on a team exceeds a threshold?

@acschang
Copy link
Contributor Author

acschang commented Jul 8, 2021

To clarify, this can potentially change the size of pointclouds (eg lidar scans etc.) received by solutions in a fully dynamic way such that anything that expects a specific formatting of the pointcloud would break (ie: assuming an rgbd sensor always has 640x480 resolution) and that this happens when all the scans over all robots on a team exceeds a threshold?

This is accurate however the deployment of this node will only affect cloud data sent from teams to the mapping server so this will not affect the functionality of your solutions in any manner. This node will affect the density of pointclouds sent to the mapping server as to stay below the 64MB transport limit.

More information on the mapping server is available on the wiki.

@acschang acschang marked this pull request as ready for review July 8, 2021 02:41
@iche033 iche033 merged commit 5239956 into final_event Jul 9, 2021
@nkoenig nkoenig deleted the mapping_server_relay_fix branch September 27, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants