Skip to content

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 16, 2021

This pull request is a proposal to keep track of the model.sdf files for:

  • MARBLE_HUSKY_SENSOR_CONFIG_3
  • MARBLE_HUSKY_SENSOR_CONFIG_4
  • MARBLE_HD2_SENSOR_CONFIG_3
  • MARBLE_HD2_SENSOR_CONFIG_4
  • CERBERUS_M100_SENSOR_CONFIG_2

motivated by issue #821

Currently the marble sensor config 3 and 4 models are equivalent to the sensor config 1 and 2 models + a thermal camera., and the cerberus sensor config 2 is a copy of config 1 with a thermal camera. They currently do not have their model.sdf files in the subt repo. Issue #812 due to us overriding the thermal changes in the model.sdfs on Fuel with changes from #798

This is a proposal to keep a reference copy in the repo so we can track its changes better with git. Note this may help with version control but adds extra maintenance effort.

Signed-off-by: Ian Chen [email protected]

@iche033 iche033 requested a review from adlarkin March 16, 2021 01:47
@peci1
Copy link
Collaborator

peci1 commented Mar 16, 2021

Also add Cerberus M100 SC2.

@iche033 iche033 changed the title Add MARBLE HUSKY and HD2 model.sdf files Add model.sdf files for robot models with a thermal camera Mar 16, 2021
@iche033
Copy link
Contributor Author

iche033 commented Mar 16, 2021

added cerberus m100 sensor config 2 in 9758867

@adlarkin
Copy link
Contributor

@iche033 I made some minor updates in b19bab4 that make it easier to compare the diff between MARBLE_HD2_SENSOR_CONFIG_1 and MARBLE_HD2_SENSOR_CONFIG_3.

@nkoenig nkoenig merged commit 8e15d26 into master Mar 29, 2021
@nkoenig nkoenig deleted the robot_model_thermal_sdf branch September 27, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants