-
Notifications
You must be signed in to change notification settings - Fork 104
Adjusted temperature variation per world #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Build finished. 21 tests run, 0 skipped, 0 failed. |
Looking through the temperature gradients in the world, the values are from 0.2 to 0.7. Here's a mapping of temperature gradient to the computed temperature range: gradient (K/m) -> range (K) if these values are fine then changes look good to me. |
@iche033 those values are fine. It seems like a very large variation, but the thermal camera output looks reasonable especially when comparing environment variation to artifact temps. Thanks! |
Adjusted ambient (in-scene) temperature variation per world to better represent contrast across different environments.
Side note: the
<temperature_gradient>
parameter does not cause ambient temperature to change by altitude as the SDFormat specs suggest.