Skip to content

Conversation

angelacmaio
Copy link
Contributor

Adjusted ambient (in-scene) temperature variation per world to better represent contrast across different environments.

Side note: the <temperature_gradient> parameter does not cause ambient temperature to change by altitude as the SDFormat specs suggest.

@angelacmaio angelacmaio requested a review from iche033 February 19, 2021 20:35
@osrf-jenkins
Copy link

Build finished. 21 tests run, 0 skipped, 0 failed.

@iche033
Copy link
Contributor

iche033 commented Feb 20, 2021

Looking through the temperature gradients in the world, the values are from 0.2 to 0.7.

Here's a mapping of temperature gradient to the computed temperature range:

gradient (K/m) -> range (K)
0.2 -> 10.0477
0.3 -> 15.0715
0.4 -> 20.0953
0.5 -> 25.1192
0.6 -> 30.143
0.7 -> 35.1668

if these values are fine then changes look good to me.

@angelacmaio
Copy link
Contributor Author

@iche033 those values are fine. It seems like a very large variation, but the thermal camera output looks reasonable especially when comparing environment variation to artifact temps. Thanks!

@nkoenig nkoenig merged commit 8d7573a into master Mar 1, 2021
@nkoenig nkoenig deleted the worlds_thermal branch September 27, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants