Skip to content

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Sep 23, 2020

New DAT files, generated using the updated visibility plugin. I regenerated the DAT file for cave_circuit_practice_02, but the old and new tiles were identical.

Signed-off-by: Nate Koenig [email protected]

@nkoenig nkoenig requested review from acschang and caguero September 23, 2020 15:46
@acschang
Copy link
Contributor

PW01 previous .dat:
pw01_old_dat

PW01 new .dat:
pw01_new_dat

PW03 previous .dat
pw03_old_dat

PW03 new .dat:
pw03_new_dat

Copy link
Contributor

@acschang acschang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The communication unit tests have identical performance while also resolving the previously noted issue 1.

@caguero
Copy link
Contributor

caguero commented Sep 23, 2020

Looks good to me as well. Here are the overlaps for cave_circuit_practice_02 before pull request #609 was merged. The big bifurcation tile was showing some suspicious overlap but that doesn't mean we were choosing the wrong tile. That might explain why the .dat doesn't change.

cave_circuit_practice_02_overlaps

@nkoenig nkoenig merged commit 1943469 into master Sep 23, 2020
@nkoenig nkoenig deleted the new_dat_files_cave branch December 10, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants