Skip to content

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Sep 9, 2020

Missing = sign when comparing reportCount to reportCountLimit.

Signed-off-by: Nate Koenig [email protected]

@nkoenig nkoenig requested a review from mjcarroll September 9, 2020 16:01
Nate Koenig added 2 commits September 9, 2020 09:22
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Copy link
Contributor

@acschang acschang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Reaches the limit then immediately sends summary and sets the status to finished.

@nkoenig nkoenig merged commit 9cb0ee8 into master Sep 16, 2020
@nkoenig nkoenig deleted the report_limit_finish branch December 10, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants