Skip to content

Spawner.rb syntax errors #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 25, 2020
Merged

Spawner.rb syntax errors #570

merged 3 commits into from
Aug 25, 2020

Conversation

acschang
Copy link
Contributor

@acschang acschang commented Aug 24, 2020 •
edited
Loading

Resolves a syntax error preventing launch of the ROBOTIKA_X2_SENSOR_CONFIG_1 model. This syntax error is not present in any other submitted model.

@acschang acschang changed the title Spwaner.rb syntax errors Spawner.rb syntax errors Aug 24, 2020
@nkoenig nkoenig self-requested a review August 24, 2020 20:05
@nkoenig nkoenig merged commit ac7e132 into master Aug 25, 2020
jisa
jisa reviewed Aug 25, 2020
View reviewed changes
Copy link

@jisa jisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it and even improving it on the way!

@nkoenig nkoenig mentioned this pull request Aug 27, 2020
Closed
@nkoenig nkoenig deleted the fix/spawner_syntax branch December 10, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jisa jisa jisa left review comments

@nkoenig nkoenig nkoenig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@acschang @jisa @nkoenig