-
Notifications
You must be signed in to change notification settings - Fork 104
Description
Please make the TEAMBASE name variable. We already had an infrastructure setup with a different base station name and it was far easier to just change the name in the launch files so we didn't have to change our other code. It looks like it only needs about 3 or 4 lines of code in each launch file to make it variable. I was able to hardcode our name by changing lines 1278, 1279 and 1370. I could probably make an edit and a pull request to make them variable, but probably easier for someone on your end to do it! This will make it easier next time you do an update so we don't have to update all of those files again.
To clarify, the biggest issue for us was in the communications nodes, which we had some code setup based on an expected static base station. I wouldn't be surprised if others had a similar setup, so changing it here makes it easier on everyone.